Repository navigation
fix: report valid color lookup values clearly - #138
Merged
Merged
Conversation
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
petercorke
approved these changes
Oct 17, 2026
Owner
|
Welcome to MVTB! Thanks for your contributions here and in RTB and bdsim. This is a lovely contribution: the old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the color.py lookup-message part of #115.
The white-point and primary-name lookups now catch KeyError rather than every exception. Their ValueError messages list the supported names with commas, instead of using the entire sentence as a separator. The original KeyError remains available as the cause.
Added two regression tests checking the exact messages and exception causes. Both tests fail against the original implementation.
Validation on Python 3.11 / OpenCV 5.0.0.93:
OpenCV 4 was not run for this PR. The other exception sites in #115 are left unchanged.