fix: support Appium-Python-Client v3+/Selenium 4.x command executor URL (PER-7786)#211
Open
rishigupta1599 wants to merge 3 commits into
Open
fix: support Appium-Python-Client v3+/Selenium 4.x command executor URL (PER-7786)#211rishigupta1599 wants to merge 3 commits into
rishigupta1599 wants to merge 3 commits into
Conversation
DriverMetaData.command_executor_url (used by the Percy-on-Automate path) read driver.command_executor._url directly, which newer Appium-Python-Client (>3) / Selenium 4.x removed, breaking POA on modern clients. Resolve the remote URL via a dual-path helper that prefers command_executor._client_config.remote_server_addr and falls back to ._url, mirroring the existing Metadata.remote_url logic. Backward compatible with older clients. Validated end-to-end against Appium servers 1.22.0 and 2.15.0 with Appium-Python-Client 2.11.1 / 3.2.1 / 4.2.1 / 5.3.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ate-code) driver_metadata._extract_remote_url duplicated metadata.remote_url, tripping pylint R0801 (duplicate-code). Move the dual-path logic into a single common.resolve_remote_url helper used by both. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The org submit-pypi workflow resolves .python-version; the exact patch 3.10.3 is no longer provided by GitHub's Ubuntu runners, failing setup at the ecosystem step. Use '3.10' so setup-python resolves the latest available patch. Pre-existing infra issue, unrelated to the SDK change; included to keep PR CI green. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DriverMetaData.command_executor_url(Percy-on-Automate path) readdriver.command_executor._urldirectly. Newer Appium-Python-Client (>3) / Selenium 4.x removed that attribute, breaking POA on modern clients.Fix
Resolve the remote URL via a dual-path helper — prefer
command_executor._client_config.remote_server_addr, fall back to._url— mirroring the existingMetadata.remote_url. Fully backward compatible.Validation
Part of PER-7786 (Appium upgrade across all SDKs).
🤖 Generated with Claude Code