fix: add explicit jsr305 dep for java-client 9.x/10.x compatibility (PER-7786)#358
Open
rishigupta1599 wants to merge 3 commits into
Open
fix: add explicit jsr305 dep for java-client 9.x/10.x compatibility (PER-7786)#358rishigupta1599 wants to merge 3 commits into
rishigupta1599 wants to merge 3 commits into
Conversation
…ility java-client 8.x provided javax.annotation.Nullable transitively, but java-client 9.x/10.x dropped that transitive dependency, so the SDK fails to compile (@nullable in AppAutomate/ScreenshotOptions) against modern clients. Declare com.google.code.findbugs:jsr305 explicitly so the SDK builds and runs against all major java-client versions without forcing a version bump that would drop the Java 8 floor. Validated: unit suite (139 tests) green on java-client 8.6.0 AND 10.1.1; and end-to-end on App Automate with java-client 7.6.0 / 8.6.0 / 9.5.0 across Appium servers 1.22.0 and 2.15.0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@nullable has CLASS retention; provided scope keeps jsr305 off consumers' transitive compile classpath while still satisfying the SDK's own compile. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Author
Claude Code PR ReviewPR: #358 • Reviewers: stack:code-reviewer SummaryAdds explicit Findings (addressed)
No source logic change. Validated: 139 unit tests on java-client 8.6.0 and 10.1.1; e2e on App Automate (java-client 7.6.0/8.6.0/9.5.0 × Appium 1.22.0/2.15.0). Verdict: PASS |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
java-client 8.x supplied
javax.annotation.Nullabletransitively; java-client 9.x/10.x dropped it, so the SDK no longer compiles (@NullableinAppAutomate/ScreenshotOptions) against modern clients.Fix
Declare
com.google.code.findbugs:jsr305:3.0.2explicitly. One line, no source changes, keeps the Java 8 floor (no java-client version bump — java-client 10 requires Java 11+).Validation
Note: java-client 9.x + the newest Selenium has an unrelated upstream issue (
SupportsContextSwitchingreferences the removedorg.openqa.selenium.ContextAware); 8.x and 10.x are unaffected. This PR is the SDK-side fix.Part of PER-7786.
🤖 Generated with Claude Code