Repository navigation
fix(filter): ignore a fully prevented clause by its query name - #194
Merged
Merged
Conversation
A filter that used the query name of a property with PreventFilter and PreventSort threw InvalidOperationException. The member name of the same property gives an ignored clause. Now the query name gives the same ignored clause as the member name, and IgnoredClauseBehavior controls it.
Behavior change: this filter no longer throws InvalidOperationException. QueryKitPropertyMappings.ReplaceAliasesWithPropertyPaths no longer throws for this query name.
Examples (Title has HasQueryName("name").PreventFilter().PreventSort(), default ReplaceWithTrue):
name == "x" && Age > 100
before: InvalidOperationException: 'Title' is not allowed for filtering or sorting.
after: (True == True) AndAlso (x.Age > 100)
name == "x" || Age > 100 (IgnoredClauseBehavior.Remove)
before: InvalidOperationException
after: x.Age > 100
From #152 on v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A filter that used the query name of a property with PreventFilter and PreventSort threw InvalidOperationException. The member name of the same property gives an ignored clause. Now the query name gives the same ignored clause as the member name, and IgnoredClauseBehavior controls it.
Behavior change: this filter no longer throws InvalidOperationException. QueryKitPropertyMappings.ReplaceAliasesWithPropertyPaths no longer throws for this query name.
Examples (Title has HasQueryName("name").PreventFilter().PreventSort(), default ReplaceWithTrue):
name == "x" && Age > 100
before: InvalidOperationException: 'Title' is not allowed for filtering or sorting.
after: (True == True) AndAlso (x.Age > 100)
name == "x" || Age > 100 (IgnoredClauseBehavior.Remove)
before: InvalidOperationException
after: x.Age > 100
From #152 on v2.