Repository navigation
fix(config): apply a property max depth only to the property and its paths - #180
Merged
Merged
Conversation
…paths
HasMaxDepth matched every path that starts with the property name, so HasMaxDepth on Address also applied to AddressBackup.State. A path could skip the global MaxPropertyDepth if its name started with a property that has a looser limit. Match the property name or the name followed by a dot.
Behavior change: HasMaxDepth on a property no longer applies to another property whose name starts with the same text. That property uses the global MaxPropertyDepth.
Examples (MaxPropertyDepth = 0, Address has HasMaxDepth(1)):
AddressBackup.State == "x"
before: filters (uses the limit of Address)
after: QueryKitPropertyDepthExceededException
sort AddressBackup.State
before: sorts
after: QueryKitPropertyDepthExceededException
Address.State == "x"
before and after: filters
From #137 on v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HasMaxDepth matched every path that starts with the property name, so HasMaxDepth on Address also applied to AddressBackup.State. A path could skip the global MaxPropertyDepth if its name started with a property that has a looser limit. Match the property name or the name followed by a dot.
Behavior change: HasMaxDepth on a property no longer applies to another property whose name starts with the same text. That property uses the global MaxPropertyDepth.
Examples (MaxPropertyDepth = 0, Address has HasMaxDepth(1)):
AddressBackup.State == "x"
before: filters (uses the limit of Address)
after: QueryKitPropertyDepthExceededException
sort AddressBackup.State
before: sorts
after: QueryKitPropertyDepthExceededException
Address.State == "x"
before and after: filters
From #137 on v2.