Repository navigation
fix(filter): resolve a child collection member in any case - #179
Merged
Merged
Conversation
The first member after a collection had to match in the exact case, and a member that did not match threw NullReferenceException. Every other segment of a property path ignores the case. Resolve the members after a collection like every other segment.
Behavior change: an unknown member after a collection follows AllowUnknownProperties. Without it, the filter throws UnknownFilterPropertyException, not NullReferenceException.
Examples:
ingredients.name == "flour"
before: NullReferenceException
after: x => x.Ingredients.Select(y => y.Name).Any(z => (z == "flour"))
Ingredients.Nope == "x"
before: NullReferenceException
after: UnknownFilterPropertyException
From #139 on v2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first member after a collection had to match in the exact case, and a member that did not match threw NullReferenceException. Every other segment of a property path ignores the case. Resolve the members after a collection like every other segment.
Behavior change: an unknown member after a collection follows AllowUnknownProperties. Without it, the filter throws UnknownFilterPropertyException, not NullReferenceException.
Examples:
ingredients.name == "flour"
before: NullReferenceException
after: x => x.Ingredients.Select(y => y.Name).Any(z => (z == "flour"))
Ingredients.Nope == "x"
before: NullReferenceException
after: UnknownFilterPropertyException
From #139 on v2.