Update style, remove old files, prepare for archiving - #2
Open
w25r wants to merge 1 commit into
Open
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
There was a problem hiding this comment.
🟢 Approval recommended
Changes are limited to documentation updates, a small IntelliJ scheme adjustment, and removal of legacy config files consistent with deprecation/archiving.
Pull request overview
This PR deprecates the repository in preparation for archiving by removing legacy Java static-analysis assets and updating the IntelliJ code style configuration and documentation to point consumers to the new canonical location.
Changes:
- Remove legacy Checkstyle/PMD XML configs and Gradle helper scripts.
- Update
README.mdto mark the repo deprecated and redirect users topayitgov/java_plugin. - Adjust the IntelliJ Java code style scheme settings (indent options and wrapping/alignment behavior).
File summaries
| File | Description |
|---|---|
| static_analysis.gradle | Removed legacy Gradle static analysis configuration (Checkstyle/PMD). |
| README.md | Marked repository deprecated and redirected style usage to payitgov/java_plugin. |
| pmd.xml | Removed legacy PMD ruleset. |
| intellij.xml | Updated IntelliJ “Payit Style” Java formatting options (indent + wrapping/alignment). |
| checkstyle.xml | Removed legacy Checkstyle ruleset. |
| checkstyle.gradle | Removed legacy Gradle Checkstyle helper script. |
| checkstyle-idea.xml | Removed legacy Checkstyle-IDEA configuration file. |
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Compliance Checklist
I have verified that this is not a new project. If it is a new project (new service, new application, new repository), I have submitted a ticket to InfoSec to review the new project and gained approval.
I have verified that the backout plan for this change conforms to our standard engineering backout plan located here. If it does not, I have documented an alternative backout plan below:
I have verified that this change is backwards compatible. If it is not, I have specified the breaking changes and how they will be handled below:
I have verified that this change will not impact the security controls built into the application or introduce any new security vulnerabilities. If it will, I have defined the security impact below:
I have verified that this change will not result in downtime. If it will, I have noted the impact below:
I have verified that no new dependencies were introduced. If they were, I have vetted them below:
I have verified that all applicable tests were updated to ensure complete test coverage of any new or modified code.
I have verified that any relevant documentation such as the README is still up to date and not impacted by my changes. If documentation needs updating for accuracy, I have done so.