Skip to content

fix: update with unified tokens#318

Merged
jeff-phillips-18 merged 11 commits into
patternfly:mainfrom
mcoker:unified-token-updates
Jun 24, 2026
Merged

fix: update with unified tokens#318
jeff-phillips-18 merged 11 commits into
patternfly:mainfrom
mcoker:unified-token-updates

Conversation

@mcoker

@mcoker mcoker commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What

Closes #312

Description

Updates some regular borders to control border. Here are some other regular borders I was curious if we should update? I couldn't find an example of these tokens in use except for the first one

  • --pf-topology__node__decorator__bg--Stroke - it's the border around the status icon. I updated the one on the left to show (dark theme)
    Screenshot 2026-06-08 at 7 00 24 PM
  • --pf-topology__node__label__icon__background--Stroke
  • --pf-topology__node--m-selected--separator--Stroke
  • --pf-topology__group--m-alt-group--topology__group__background--Stroke
  • --pf-topology__group__collapsed-badge__node__label__badge__rect--Stroke
  • --pf-topology__edge--m-hover--background--Stroke
  • These 3 all look like they go together:
    • --pf-topology-default-create-connector--m-hover--line--Stroke
    • --pf-topology-default-create-connector--m-hover--arrow--Fill
    • --pf-topology-default-create-connector--m-hover--arrow--Stroke

@patternfly-build

patternfly-build commented Jun 9, 2026

Copy link
Copy Markdown

@mcoker mcoker requested a review from andrew-ronaldson June 9, 2026 00:13
@mcoker mcoker force-pushed the unified-token-updates branch from 3a5a036 to a88a2ed Compare June 9, 2026 22:37
@mcoker

mcoker commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson updated all of the icons I could find with RH equivalents. The only icon I couldn't find an equivalent for was the skull icon used here?

import SignOutAltIcon from '@patternfly/react-icons/dist/esm/icons/skull-icon';

Looks like it's on the "topology package" demo if you turn on node icons

Screenshot 2026-06-09 at 9 14 29 PM

@jeff-phillips-18

Copy link
Copy Markdown
Member

@andrew-ronaldson updated all of the icons I could find with RH equivalents. The only icon I couldn't find an equivalent for was the skull icon used here?

import SignOutAltIcon from '@patternfly/react-icons/dist/esm/icons/skull-icon';

@mcoker Feel free to replace it with anything. It is only for demo purposes.

@mcoker

mcoker commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@jeff-phillips-18 thanks updated! The icon is only half visible but looks like that's a pre-existing issue.

Screenshot 2026-06-10 at 10 09 15 AM

what it looks like on main now

Screenshot 2026-06-10 at 10 47 38 AM

@mcoker

mcoker commented Jun 17, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson fixed the demo app issue, I needed to update patternfly versions in there as well. You can run it locally - you'll need to pull the latest from my branch, run yarn install, then start the dev and demo app servers to see the change. I also published the demo app here if that's easier - http://pf-topology-unified.surge.sh/

@andrew-ronaldson

Copy link
Copy Markdown
Collaborator

Can you update the decorators to also have the control tokens.
Screenshot 2026-06-22 at 10 34 56 AM

@mcoker

mcoker commented Jun 22, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson updated good sir - http://pf-topology-unified.surge.sh/

Also noticed the icon circle uses the regular border token. Is that ok or want me to update that to the control token, too?

Screenshot 2026-06-22 at 3 15 40 PM

@andrew-ronaldson

Copy link
Copy Markdown
Collaborator

let's make everything control for more contrast please and thank you

@mcoker

mcoker commented Jun 23, 2026

Copy link
Copy Markdown
Contributor Author

@andrew-ronaldson updated

@mcoker mcoker requested a review from jeff-phillips-18 June 23, 2026 20:32
@jeff-phillips-18

Copy link
Copy Markdown
Member

@mcoker The demo app is not displaying correctly:

image

Created the demo app surge: https://unified-token-updates.surge.sh/

@jeff-phillips-18

Copy link
Copy Markdown
Member

@mcoker Never mind, my mistake! For some reason my yarn install failed and I hadn't noticed.

updated the surge at: https://unified-token-updates.surge.sh/

@jeff-phillips-18 jeff-phillips-18 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jeff-phillips-18 jeff-phillips-18 merged commit e795e7b into patternfly:main Jun 24, 2026
9 checks passed
@github-actions

Copy link
Copy Markdown

🎉 This PR is included in version 6.6.0-prerelease.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unified theme: Topology token updates

4 participants