Skip to content

fix(CodeEditor): Adjust sizeToFit height bug #12529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rebeccaalpert wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −0
Open

fix(CodeEditor): Adjust sizeToFit height bug #12529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/react-code-editor/src/components/CodeEditor/CodeEditor.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -386,6 +386,9 @@ export const CodeEditor = ({
editorRef.current = editor;
if (height === 'sizeToFit') {
setHeightToFitContent();
editor.onDidContentSizeChange(() => {
setHeightToFitContent();
});
Comment on lines 388 to +391

@thatblindgeye thatblindgeye Jun 29, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need both calls to setHeightToFitContent? Assuming the first is for an initial render and second is more the dynamic change when typing in the code editor, but just wanna confirm

}
};

Expand Down
Loading