Skip to content

Bug: Clarify MenuToggle typing for aria-haspopup="true" #12674

Description

@patternfly-jira-sync

Found during testing

With @patternfly/react-core@6.7.0-prerelease.4, MenuToggleProps rejects the string value "true" for aria-haspopup, adding a new TypeScript error in an existing Console usage. Confirm whether this is an intentional breaking type change; if so, document the migration clearly, or preserve compatibility if the string form is intended to remain supported.
Acceptance criteria:

  • The supported aria-haspopup values are explicit in the public MenuToggle types and documentation.

  • The release notes identify the change and show the supported replacement, if the API change is intentional.

  • A consumer using the documented value type-checks successfully.


Jira Issue: PF-4712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions