Repository navigation
feat(text-input)!: port to <pf-v6-text-input>
#3160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
7fb7155
5c1ca40
6bf0009
9c38844
f1eb403
af1aabd
71ba5c0
9dcc7d9
99ff953
b857d1e
e4ef60d
1d2c016
7d73cbb
627ad1d
7cbfb0d
d58d9fb
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@patternfly/pfe-tools": patch | ||
| --- | ||
|
|
||
| Added `readonly` and `invalid` properties to a11y snapshot type |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| "@patternfly/pfe-core": patch | ||
| --- | ||
|
|
||
| `InternalsController`: expose `form`, `validationMessage`, and `willValidate` getters. Previously returned `undefined` despite TypeScript accepting the access. Form-associated elements can read the associated form reference and validation state from the controller. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| --- | ||
| "@patternfly/elements": major | ||
| --- | ||
|
|
||
| `<pf-v6-text-input>`: replaces `<pf-v5-text-input>` with PatternFly v6 design specs. | ||
|
|
||
| ```html | ||
| <label for="name">Name</label> | ||
| <pf-v6-text-input id="name" name="name"></pf-v6-text-input> | ||
| ``` | ||
|
|
||
| **Breaking Changes from v5** | ||
|
|
||
| - Renamed tag from `<pf-v5-text-input>` to `<pf-v6-text-input>` | ||
| - CSS custom properties renamed from `--pf-v5-c-form-control--*` to `--pf-v6-c-form-control--*` | ||
| - `left-truncated` attribute replaced by `truncated="start"` enum | ||
| - `icon` / `custom-icon-url` / `custom-icon-dimensions` attributes replaced by `icon` slot | ||
| - `validate-on` and `error-text` attributes removed | ||
|
|
||
| **New features** | ||
|
|
||
| - `referenceTarget` support for native cross-root label association | ||
| - `validated="error"` state with `aria-invalid` and `role="alert"` status message | ||
| - Constraint validation via `checkValidity()`, `reportValidity()`, `setCustomValidity()` | ||
| - `maxlength`, `minlength`, and `inputmode` attributes | ||
| - `select()` method | ||
| - `icon` slot for custom icon content | ||
| - Cancelable `change` event | ||
| - v6 design tokens and `light-dark()` support | ||
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the changelog feature list.
This changelog lists two features that the code does not ship:
referenceTargetsupport. The PR removed that support, and the README describes only thedelegatesFocusandaccessible-labelfallbacks.changeevent".#onChangedispatchesnew Event('change', { bubbles: true }), which is not cancelable, and the spec assertscancelable === false.Users will read this published changelog, so remove or correct both entries.
Proposed fix
📝 Committable suggestion
🤖 Prompt for AI Agents