Refactor mouse location handling in ruler classes#264
Merged
pascalpp merged 1 commit intoJun 23, 2026
Merged
Conversation
* Simplified mouse location updates in AppDelegate by removing unnecessary rounding. * Introduced dedicated methods in HorizontalRule and VerticalRule for rounding mouse coordinates, enhancing code clarity and maintainability. * Added unit tests to verify the rounding functionality for mouse coordinates in ruler classes.
Owner
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
pascalpp
commented
Jun 20, 2026
pascalpp
left a comment
pascalpp
left a comment
Owner
Author
There was a problem hiding this comment.
[codex reviewer] Reviewed the diff and did not find any blocking issues. Moving rounding from AppDelegate into the local horizontal/vertical rule coordinate paths keeps the live mouse tick aligned after view conversion, and the added boundary assertions cover the new helpers.
I also ran:
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTests -derivedDataPath build/DerivedData
Result: passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #263