Skip to content

Verify flippable ruler integration#206

Merged
pascalpp merged 2 commits into
pascal/195-flip-ruler-uifrom
pascal/197-flip-ruler-integration
Jun 13, 2026
Merged

Verify flippable ruler integration#206
pascalpp merged 2 commits into
pascal/195-flip-ruler-uifrom
pascal/197-flip-ruler-integration

Conversation

@pascalpp

Copy link
Copy Markdown
Owner

Summary

  • Add integration coverage for flipped mouse labels across pixels, millimeters, and inches.
  • Verify reset position uses the active zero corner and keeps default flipped rulers on a shared zero point.
  • Runs the required core test command for the final flippable-ruler verification ticket.

Validation

  • xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTests

Part of #192. Addresses #197.

Copilot AI review requested due to automatic review settings June 13, 2026 06:27
@pascalpp pascalpp marked this pull request as ready for review June 13, 2026 06:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds integration-oriented unit tests to validate the “flippable ruler” (zero-corner) feature, specifically covering mouse number label formatting across units after flips, and ensuring reset-position behavior honors the active zero corner and maintains a coherent shared corner layout (as required by issues #192 and #197).

Changes:

  • Add a test ensuring mouse number labels (px/mm/in) remain correct after flipping to a non-default zero corner.
  • Add tests verifying resetPosition() uses the current prefs.zeroCorner and preserves a shared zero point for flipped default layouts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread FreeRulerTests/RulerCoreTests.swift

pascalpp commented Jun 13, 2026

Copy link
Copy Markdown
Owner Author

This was referenced Jun 13, 2026
@pascalpp pascalpp force-pushed the pascal/195-flip-ruler-ui branch from 121c669 to 04e005c Compare June 13, 2026 07:08
@pascalpp pascalpp force-pushed the pascal/197-flip-ruler-integration branch from 2ea112e to e5d1752 Compare June 13, 2026 07:09
Copilot AI review requested due to automatic review settings June 13, 2026 16:07
@pascalpp pascalpp force-pushed the pascal/197-flip-ruler-integration branch from e5d1752 to f08d72b Compare June 13, 2026 16:07
@pascalpp pascalpp force-pushed the pascal/195-flip-ruler-ui branch from 04e005c to db245c7 Compare June 13, 2026 16:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

@pascalpp pascalpp merged commit 1d60b1a into pascal/195-flip-ruler-ui Jun 13, 2026
1 check passed
@pascalpp pascalpp deleted the pascal/197-flip-ruler-integration branch June 13, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants