Persist zero-corner preference#200
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a persisted “zero corner” preference (four-state model) so the app can remember which corner acts as the shared ruler origin across launches, and ensures UI test runs reset that preference deterministically.
Changes:
- Add a four-state
ZeroCornermodel and expose it as a newPrefs.zeroCornerpreference. - Persist
prefs.zeroCornerviaUserDefaultswith fallback-to-.topLeftloading. - Add unit tests validating raw-value stability, fallback loading, and write-through to
UserDefaults.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| FreeRulerTests/RulerCoreTests.swift | Adds tests for ZeroCorner raw values, fallback loading, and persistence to UserDefaults (plus a restore helper). |
| Free Ruler/Ruler.swift | Introduces the ZeroCorner enum used by preferences and persistence. |
| Free Ruler/Prefs.swift | Adds zeroCorner to default registration, loads it with fallback, and persists changes via KVO observation. |
| Free Ruler/AppDelegate.swift | Resets zeroCorner during UI-test state reset alongside other preferences. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZeroCornermodel for ruler zero-corner selectionprefs.zeroCornerthroughUserDefaults, defaulting invalid or missing values to top-leftValidation
xcodebuild -project "Free Ruler.xcodeproj" -scheme "Free Ruler" test -only-testing:FreeRulerTestsStacked on #199 for the first child issue from #192: Persist zero-corner state.