fix(cli): preserve configured Mint host origin - #778
Open
Zhao0335 wants to merge 1 commit into
Open
Conversation
|
I hit an error while handling your request (Model unavailable on AI Gateway free tier: Free tier users do not have access to this model. Upgrade to paid credits at https://vercel.com/d?to=%2F%5Bteam%5D%2F%7E%2Fai%3Fmodal%3Dtop-up for unrestricted…). Please try again, rephrase, or reach out if it keeps failing. Error id: a9468be0-58ae-4c76-9502-f93c0fd6e0d9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Preserves an operator-provided MINT_PASCAL_HOST_ORIGIN when the CLI starts the managed editor process, while retaining the existing pascal.localhost URL as the fallback when no value is configured.
Adds a regression test that starts the managed runtime and verifies the origin received by the spawned editor process.
Fixes #765
How to test
Local verification: the targeted regression test, CLI TypeScript checks, CLI build, and Biome checks for both changed files pass. The full Windows test run reaches the repository's existing platform-specific failures around POSIX permission bits, process-command verification, and URL pathname globbing; the new test passes in that run.
Screenshots / screen recording
Not applicable; this changes CLI process environment propagation only.
Checklist
Note
Low Risk
Small CLI environment propagation change with a targeted regression test; no auth or data-path changes.
Overview
When the CLI spawns the managed editor,
MINT_PASCAL_HOST_ORIGINis no longer forced to the localpascal.localhostURL. It now uses an operator-set value from the environment when present, and only falls back tostate.urlwhen unset.A regression test starts the managed runtime with
MINT_PASCAL_HOST_ORIGINconfigured and asserts the spawned editor process sees that origin (via a test-only/mint-originhandler on the fake runtime server).Reviewed by Cursor Bugbot for commit 7c07eaf. Bugbot is set up for automated code reviews on this repo. Configure here.