Skip to content

fix: create/update sql filters - #1824

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/create-sql-filters
Oct 15, 2026
Merged

nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:fix/create-sql-filters

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

currently failing because UI sends stream_name=sql in create/update filters when called from sql editor

the stream name validation was added in the PR
#1727

for a security fix
GHSA-q8xx-r33r-6mwv

with this change, the security fix still works
also, UI will be able to save the filter as-is

Summary by CodeRabbit

  • Bug Fixes
    • SQL filters now consistently use the "sql" stream name and are not subject to user-defined stream-name validation. Other filter types continue to be validated as before.

currently failing because UI sends `stream_name=sql` in create/update filters
when called from sql editor

the stream name validation was added in the PR
parseablehq#1727

for a security fix
GHSA-q8xx-r33r-6mwv

with this change, the security fix still works
also, UI will be able to save the filter as-is
@coderabbitai

coderabbitai Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: fa8b37c0-0f06-43ec-8ed9-cf56680ec798
📥 Commits

Reviewing files that changed from the base of the PR and between c94bd14 and 8e20900.

📒 Files selected for processing: 1
  • src/handlers/http/users/filters.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

Filter creation and updates now pass the filter type to stream-name validation. SQL filters use the fixed stream name "sql"; other filter types retain user-defined name validation.

Changes

Filter stream-name validation

Layer / File(s) Summary
Type-aware stream-name validation
src/handlers/http/users/filters.rs
The validator replaces SQL filter stream names with "sql" and retains existing validation for other filter types. Filter creation, updates, and tests use the updated validator.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Bug fix

Suggested reviewers: parmesant

Merge Risk: ⚪ Minimal · up to 8e209

No actionable merge-blocking issue is established; the change is mergeable after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 37.50% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 8 functions across 1 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly identifies the main change: fixing creation and updates for SQL filters.
Description check Passed The description explains the failure, the cause, the security context, and the intended result. It does not include the template headings or explicit checklist status, but the required change rational…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checked the stream-name gate,
And found SQL a fixed new state.
Flat names pass and paths are turned,
The tests confirm what has been learned.
Then off through fields of green I raced.

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit a5976d2 into parseablehq:main Oct 15, 2026
13 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants