Repository navigation
fix: create/update sql filters - #1824
Merged
nikhilsinhaparseable merged 1 commit intoOct 15, 2026
Merged
nikhilsinhaparseable merged 1 commit into
nikhilsinhaparseable merged 1 commit into
Conversation
currently failing because UI sends `stream_name=sql` in create/update filters when called from sql editor the stream name validation was added in the PR parseablehq#1727 for a security fix GHSA-q8xx-r33r-6mwv with this change, the security fix still works also, UI will be able to save the filter as-is
Contributor
praveen5959
approved these changes
Oct 15, 2026
nikhilsinhaparseable
merged commit Oct 15, 2026
a5976d2
into
parseablehq:main
13 of 16 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
currently failing because UI sends
stream_name=sqlin create/update filters when called from sql editorthe stream name validation was added in the PR
#1727
for a security fix
GHSA-q8xx-r33r-6mwv
with this change, the security fix still works
also, UI will be able to save the filter as-is
Summary by CodeRabbit
"sql"stream name and are not subject to user-defined stream-name validation. Other filter types continue to be validated as before.