Skip to content

remove pmeta creation - #1822

Merged
nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove-unused-pmeta
Oct 13, 2026
Merged

nikhilsinhaparseable merged 1 commit into
parseablehq:mainfrom
nikhilsinhaparseable:remove-unused-pmeta

Conversation

@nikhilsinhaparseable

@nikhilsinhaparseable nikhilsinhaparseable commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Behavior Changes

    • The service no longer automatically creates or synchronizes its internal metadata stream when the query server starts. Environments that relied on startup to create this stream may need to account for its absence.
  • Internal Changes

    • Removed the associated stream-creation and synchronization behavior.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 50938ac2-b6bd-4c1a-a9e4-c05055ace094
📥 Commits

Reviewing files that changed from the base of the PR and between e3e4c8c and b647075.

📒 Files selected for processing (2)
  • src/handlers/http/modal/query_server.rs
  • src/parseable/mod.rs
💤 Files with no reviewable changes (1)
  • src/handlers/http/modal/query_server.rs

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The startup path no longer calls create_internal_stream_if_not_exists. That method and its supporting imports were removed from Parseable.

Changes

Internal stream startup

Layer / File(s) Summary
Remove internal stream creation
src/parseable/mod.rs, src/handlers/http/modal/query_server.rs
Removed the method that created the internal PMETA stream and synchronized newly created streams with ingestors. QueryServer::init now proceeds from migrations to load_on_init without calling that method.

Priority: ⚪ Not assessed

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Refactor

Suggested reviewers: parmesant

Merge Risk: ⚪ Minimal · up to b6470

No concrete failure from deferring PMETA creation was established; the change is mergeable after normal checks.

Pre-merge checks · Passed 4 · Failed 1

Failed Failed checks (1 warning)

Check name Status Explanation Resolution
Description check Warning No pull request description was provided. The required Description section, rationale, key changes, issue reference handling, and test checklist are missing. Add a pull request description that explains the goal, chosen solution and rationale, key changes, relevant issue reference or removal of the issue placeholder, and applicable testing or documentation checklist items.
Passed Passed checks (4 passed)
Check name Status Explanation
Title check Passed The title clearly summarizes the main change: removal of PMETA creation. It is concise and relevant.
Docstring Coverage Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 1 files.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

A rabbit checks the startup trail,
Where stream-creation steps grew pale.
Migrations run, then loading starts,
No PMETA sync now plays its part.
The rabbit hops beneath the moon.

Comment @coderabbitai help to get the list of available commands.

@nikhilsinhaparseable
nikhilsinhaparseable merged commit c7dfbef into parseablehq:main Oct 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants