fix: Relation count query bypasses protectedFields for identity-scoped groups (GHSA-rmhf-xv62-rm99)

[mtrezza]

Issue

Relation count query bypasses protectedFields for identity-scoped groups (GHSA-rmhf-xv62-rm99)

Tasks

• Add tests
• Add changes to documentation (guides, repository pages, in-code descriptions)
• A breaking change to be announced in a future release
• Impacts performance

[parse-github-assistant]

🚀 Thanks for opening this pull request! We appreciate your effort in improving the project. Please let us know once your pull request is ready for review.

Tip

• Keep pull requests small. Large PRs will be rejected. Break complex features into smaller, incremental PRs.
• Use Test Driven Development. Write failing tests before implementing functionality. Ensure tests pass.
• Group code into logical blocks. Add a short comment before each block to explain its purpose.
• We offer conceptual guidance. Coding is up to you. PRs must be merge-ready for human review.
• Our review focuses on concept, not quality. PRs with code issues will be rejected. Use an AI agent.
• Human review time is precious. Avoid review ping-pong. Inspect and test your AI-generated code.

Note

Please respond to review comments from AI agents just like you would to comments from a human reviewer. Let the reviewer resolve their own comments, unless they have reviewed and accepted your commit, or agreed with your explanation for why the feedback was incorrect.

Caution

Pull requests must be written using an AI agent with human supervision. Pull requests written entirely by a human will likely be rejected, because of lower code quality, higher review effort and the higher risk of introducing bugs. Please note that AI review comments on this pull request alone do not satisfy this requirement. Our CI and AI review are safeguards, not development tools. If many issues are flagged, rethink your development approach. Invest more effort in planning and design rather than using review cycles to fix low-quality code.

[coderabbitai]

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Essentials

Run ID: 71c0796d-52fe-48ee-8e24-8c7cd63aaba4

📥 Commits

Reviewing files that changed from the base of the PR and between 1581bda and 074ad6a.

📒 Files selected for processing (2)

• spec/vulnerabilities.spec.js
• src/RestQuery.js

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

Count queries now pass authentication context to database.find. End-to-end tests verify authorization for $relatedTo counts on protected relation fields.

Changes

Protected relation count authorization

Layer / File(s)	Summary
Count authorization context and coverage src/RestQuery.js, spec/vulnerabilities.spec.js	runCount passes this.auth to database.find. Tests verify caller-specific, role-based, user-specific, public, master, and maintenance-key behavior, including protection against object ID membership oracles.

Priority: ⬆️ High

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 074ad

Count requests now pass caller authentication to authorization checks, with coverage for protected relation fields. The change is ready to merge.

---

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Engage In Review Feedback	❓ Inconclusive	The supplied review metadata reports zero actionable findings for the current review. It does not establish whether earlier review feedback comments exist or whether the contributor engaged with, impl…	Provide the complete review discussion history, including earlier comments and contributor responses or commits. Confirm that each feedback comment received prior engagement and was either implemented or retracted by the reviewer.

✅ Passed checks (6 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Security Check	✅ Passed	The production change is a security fix, not a new vulnerability. The only source change passes this.auth to database.find in runCount, matching the existing authenticated runFind path. `Datab…
Title check	✅ Passed	The title begins with the required fix: prefix, uses a capitalized first word, and accurately describes the protected relation count query fix.
Description check	✅ Passed	The description identifies the security issue and confirms test coverage. It omits the ## Pull Request and ## Approach sections and does not include all template task items, but it provides the cr…

Full details: Engage In Review Feedback

Explanation

The supplied review metadata reports zero actionable findings for the current review. It does not establish whether earlier review feedback comments exist or whether the contributor engaged with, implemented, or resolved that feedback.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create a new PR

---

_{Comment @coderabbitai help to get the list of available commands.}

[mtrezza]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.55%. Comparing base (1cd1f8f) to head (074ad6a).
⚠️ Report is 1 commits behind head on release-8.x.x.

Additional details and impacted files

@@                Coverage Diff                @@
##           release-8.x.x   #10668      +/-   ##
=================================================
+ Coverage          92.14%   92.55%   +0.41%     
=================================================
  Files                192      192              
  Lines              16252    16252              
  Branches             238      238              
=================================================
+ Hits               14975    15042      +67     
+ Misses              1252     1189      -63     
+ Partials              25       21       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[parseplatformorg]

🎉 This change has been released in version 8.6.93