Add Mechanism::AesCtr - #365
Merged
wiktor-k merged 2 commits intoAug 20, 2026
Merged
Conversation
hug-dev
reviewed
Aug 20, 2026
hug-dev
left a comment
hug-dev
left a comment
Member
There was a problem hiding this comment.
Thank you! Looks good with a small comment. You might need to sign-off your commit (git commit --signoff) for the DCO check to pass :)
wiktor-k
previously approved these changes
Aug 20, 2026
Signed-off-by: Sietse Ringers <mail@sietseringers.net>
sietseringers
force-pushed
the
add-aes-ctr-mechanism
branch
from
August 20, 2026 12:22
4e65739 to
f3c06ff
Compare
Add empty line after header in rustdoc Co-authored-by: Wiktor Kwapisiewicz <wiktor@metacode.biz> Signed-off-by: Sietse Ringers <sietseringers@users.noreply.github.com>
hug-dev
approved these changes
Aug 20, 2026
Contributor
Author
|
Great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for the
CKM_AES_CTRmechanism, which was already exposed as aMechanismTypebut could not be used as aMechanismbecause its parameter type had no safe wrapper.I am interested in this because I am thinking of basing an implementation of AES-SIV (RFC 5297) on top of this, which is based on AES-CTR.
Changes
AesCtrParams, which is a#[repr(transparent)]wrapper aroundCK_AES_CTR_PARAMS.Mechanism::AesCtr(AesCtrParams)variant, wired intoMechanism::mechanism_type().