Add shadow to sticky headers to improve visual clarity#404
Closed
BenjaminSchaaf wants to merge 1 commit into
Closed
Add shadow to sticky headers to improve visual clarity#404BenjaminSchaaf wants to merge 1 commit into
BenjaminSchaaf wants to merge 1 commit into
Conversation
Collaborator
|
Looks good. braver did no shadows at all I think, but to me it looks good. There is minor lint and at most one could say 
that the div is looking strange, and an attribute or class-name saying, "hej, I'm a scroll position sentinel. I have no content" would be ok. |
BenjaminSchaaf
force-pushed
the
sticky-header-shadows
branch
from
5af5b0c to
3fcf7f0
Compare
Author
|
I've pushed those changes |
Collaborator
|
Easier when you tick the "allow maintainers to edit" 
|
Collaborator
|
I just pick the one commit directly. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.