[dropshot-api-manager] track per-file state and parse reasons in problems - #126
Merged
sunshowers merged 2 commits intoAug 15, 2026
Conversation
Created using spr 1.3.6-beta.1
Created using spr 1.3.6-beta.1
sunshowers
commented
Aug 15, 2026
Comment on lines
11
to
+14
| does not match the blessed (upstream) OpenAPI document: versioned- | ||
| health/versioned-health-2.0.0-ffffff.json.gitstub. This can | ||
| happen if you created this version of the API in this branch, then | ||
| merged with an upstream commit that also added the same version | ||
| number. In that case, you likely already bumped your local | ||
| version number (when you merged the list of supported versions in | ||
| Rust) and this file is vestigial. This tool can remove the unused | ||
| file for you. | ||
| health/versioned-health-2.0.0-ffffff.json.gitstub (could not | ||
| be parsed: Git stub "versioned-health/versioned-health-2.0.0- | ||
| ffffff.json.gitstub": resolved contents have hash "511899", but |
Collaborator
Author
There was a problem hiding this comment.
the duplicate file name here will be fixed in a subsequent commit
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problems that track unparseable files now say what's going on in more detail.
Within a problem summary,
ProblemKind's per-file variants gain aFileValidityenum so that tests can assert on that.