Repository navigation
Conversation
leftwo
force-pushed
the
alan/crutest-live-replace-fresh
branch
from
November 6, 2026 21:08
c4208a9 to
67e9722
Compare
After each live repair in the replace workload, give the downstairs that was replaced a new, empty region before it is used as the next replacement. This makes it look like the new region the control-plane would provide, instead of reusing a region that was already part of the volume and would come with been_active status we don't want. Add a dsc endpoint instead of targets to the replace workload in the live repair buildomat job.. If the replace task ends, stop the IO task instead of running IO until the count is reached.
leftwo
force-pushed
the
alan/crutest-live-replace-fresh
branch
from
November 6, 2026 21:19
67e9722 to
918d2d3
Compare
leftwo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the crutest replace workload after each live repair, give the
downstairs that was replaced a new empty region before it is used as
the next replacement. This matches what the control plane does
and avoids re-use of an existing region which comes with been_active
set (which we don't want)
This uses the dsc recreate from #2073 and the crutest recreate_downstairs
from #2074.
The replace workload now requires --dsc, so update the buildomat job
to switch to that instead of providing targets.
If the replace task ends, the IO task now stops instead of running IO
until the count is reached, so a replace failure is reported right away.