Don't show fractional bytes in file size display#3210
Merged
david-crespo merged 5 commits intomainfrom May 6, 2026
Merged
Conversation
filesize's `pad: true` option pads results like "5 B" to "5.00 B", but fractional bytes are nonsensical. Add a `formatBytes` wrapper that suppresses padding when the unit is bytes, and use it in FileInput and the image upload progress display. Closes #3209
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
Author
|
Initial Claude solution was sufficient to fix the problem, but caused some fragmentation by introducing a new helper that we only use in some spots. I updated the helper so it could be used everywhere we currently call |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
filesize's
pad: trueoption pads results like "5 B" to "5.00 B", butfractional bytes are nonsensical. Add a
formatByteswrapper thatsuppresses padding when the unit is bytes, and use it in FileInput and
the image upload progress display.
Closes #3209