refactor: [DC-352] allow aborted syncs to finish before commencing final teardown routines - #12641
Open
modSpike wants to merge 1 commit into
Open
refactor: [DC-352] allow aborted syncs to finish before commencing final teardown routines#12641modSpike wants to merge 1 commit into
modSpike wants to merge 1 commit into
Conversation
for removing folders permanently (either from remove folder sync or remove whole account) wipeForRemoval now waits for any running sync to finish before completing the teardown. For application shutdown, which triggered an assert on isSyncRunning in Folder dtr, folderman now aborts any running sync (previously it just let them run!) and waits for completion before doing the final folder cleanup. Also renamed FolderMan::unloadAndDeleteAllFolders to FolderMan::shutdown (for more clarity re: when it should be used)
|
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
modSpike
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see https://kiteworks.atlassian.net/browse/DC-352