Skip to content

[FEATURE REQUEST] Edit link over a space#4817

Open
joragua wants to merge 14 commits intomasterfrom
feature/edit_space_link
Open

[FEATURE REQUEST] Edit link over a space#4817
joragua wants to merge 14 commits intomasterfrom
feature/edit_space_link

Conversation

@joragua
Copy link
Copy Markdown
Contributor

@joragua joragua commented Apr 9, 2026 •
edited
Loading

Related Issues

App: #4756

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Apr 9, 2026
@joragua joragua force-pushed the feature/edit_space_link branch from 68b51f8 to 02b0e0e Compare April 9, 2026 11:28
@joragua joragua linked an issue Apr 9, 2026 that may be closed by this pull request
[FEATURE REQUEST] Edit a link over a space #4756
Open
12 tasks
@joragua joragua force-pushed the feature/edit_space_link branch 3 times, most recently from 3c30678 to c5a3011 Compare April 10, 2026 08:26
@jesmrec jesmrec force-pushed the feature/edit_space_link branch from 064f233 to dc46bde Compare April 10, 2026 11:27
@joragua joragua force-pushed the feature/edit_space_link branch from dc46bde to 8b936a5 Compare April 13, 2026 11:36
@joragua joragua closed this Apr 13, 2026
@joragua joragua force-pushed the feature/edit_space_link branch from 8b936a5 to 6ac162b Compare April 13, 2026 11:45
@jesmrec jesmrec reopened this Apr 13, 2026
@joragua joragua force-pushed the feature/edit_space_link branch 3 times, most recently from 076c8ac to d51f23a Compare April 17, 2026 12:54
@joragua joragua force-pushed the feature/edit_space_link branch from 4822a5c to 6f9dd9c Compare April 22, 2026 07:30
@joragua joragua marked this pull request as ready for review April 22, 2026 07:39
@joragua joragua requested a review from jesmrec April 22, 2026 07:40
jesmrec
jesmrec requested changes Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments from my side @joragua!

Comment thread ...oudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt
Comment thread ...oudApp/src/main/java/com/owncloud/android/presentation/spaces/links/AddPublicLinkFragment.kt
Comment thread ...ComLibrary/src/main/java/com/owncloud/android/lib/resources/links/services/OCLinksService.kt Outdated
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/links/SpaceLinksViewModel.kt
@joragua joragua force-pushed the feature/edit_space_link branch 2 times, most recently from 0731cc7 to a5263f7 Compare April 27, 2026 10:49
@joragua joragua force-pushed the feature/edit_space_link branch from a5263f7 to 30b0258 Compare April 27, 2026 10:52
@joragua joragua requested a review from jesmrec April 27, 2026 11:14
jesmrec
jesmrec approved these changes Apr 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jesmrec jesmrec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR approved, moving to QA

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Edit a link over a space

2 participants

@joragua @jesmrec