chore: drop the inactive .drone.star Drone CI config - #713
Merged
Merged
Conversation
The repository migrated to GitHub Actions in #575, but `.drone.star` was left behind — unlike the sibling images, which deleted theirs in the same move (owncloud-docker/php#232, owncloud-docker/ubuntu#231, owncloud-docker/base#422). Nothing executes it: `.github/workflows/main.yml` owns the whole pipeline (lint, multiarch build, smoke test, Trivy scan, push, Docker Hub description), and the starlark file's contents are ~18 months stale, still building 11.0.0-prealpha, 10.16.1 and 10.15.3 from download.owncloud.com. It was not merely dead weight, though. `owncloud-ops/renovate-presets:base` carries a customManager matching `(^|/)\.drone\.star$`, so all six `*_IMAGE` constants at the top of the file were live Renovate dependencies. That produced manual noise (#707, mariadb 10.11 -> 13.0) and, because the docker preset automerges digest updates for mariadb/redis/ubuntu/owncloud, unattended commits to a file nobody runs (995265b, #659). Also drops the now-unreachable `.drone.yml` entry from `.gitignore` — it only ever ignored the starlark-generated output — and the two `.drone.star` references in `agents.md`. No CI coverage is lost. Drone's lint pipeline ran buildifier on `.drone.star` itself plus an editorconfig check that `lint-editorconfig.yml` now performs, and its shellcheck step globbed `<base>/overlay/`, which holds only `.keep` files. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Signed-off-by: Thomas Müller <thomas.mueller@owncloud.com>
1 task
phil-davis
approved these changes
Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the root cause behind #707.
Why
This repository migrated to GitHub Actions in #575, but
.drone.starwas left behind — unlike the sibling images, which deleted theirs in the same move: owncloud-docker/php#232, owncloud-docker/ubuntu#231, owncloud-docker/base#422. Of all non-archived repos in this org, onlyserverandhelm-chartsstill carry one.Nothing executes it:
.github/workflows/main.ymlowns the whole pipeline — editorconfig lint, multiarch build, smoke test onstatus.php, Trivy with per-version ignore files, Docker Hub push and description sync.11.0.0-prealpha,10.16.1and10.15.3fromdownload.owncloud.com, and pushes throughregistry.drone.owncloud.com.agents.mdalready told readers to ignore it.It was not merely dead weight, though.
owncloud-ops/renovate-presets:basecarries acustomManagersentry withfileMatch: ["(^|/)\\.drone\\.star$"]matching.+_IMAGEassignments, so all six image constants at the top of the file were live Renovate dependencies — the Dependency Dashboard (#241) lists them underregex (1) → .drone.star (6). That produced both manual noise (#707: mariadb10.11→13.0) and, because the:dockerpreset automerges digest updates formariadb|redis|ubuntu|owncloud/*, unattended commits to a file nobody runs (995265b, #659).What
.drone.star(706 lines)..drone.ymlentry from.gitignore— it only ever ignored the starlark-generated output, and nothing generates it any more..drone.starreferences fromagents.md.No
CHANGELOG.mdentry: the date-based changelog tracks published-image content, and the GHA migration itself (#575) added none either. Nothing about the built image changes here.No CI coverage is lost
lintpipeline ranbuildifieron.drone.staritself, plus an editorconfig check that the reusablelint-editorconfig.ymlnow performs.shellcheckstep globbed<base>/overlay/, which contains only.keepfiles — zero files were ever checked.registry.drone.owncloud.comand the stale tarballs above; they cannot run.The one pipeline never ported to Actions is the webUI/Selenium acceptance job. That is a pre-existing gap, tracked by #577 and in progress in #677 (api + cli). For anyone reviving it, the pipeline definition is
def uiat line 543 of the file as it stood at its last commit:Verification
grep -rni drone . --exclude-dir=.git→ one hit, the historicalCHANGELOG.md:45entry from 2020, which stays.grep -rn drone .github/→ no hits; no workflow, Dependabot or Renovate config points at the file.editorconfig-checkerrun locally over the result:0 errors found, 19 files checked(and confirmed able to fail, by probing it with a trailing-whitespace file).regex (1) → .drone.star (6)section on Renovate's next run, leaving onlydockerfile (2)andgithub-actions (2).🤖 Generated with Claude Code