Skip to content

chore: remove macos-14 from ci.yaml - #3652

Merged
airween merged 1 commit into
owasp-modsecurity:v3/masterfrom
airween:v3/removemacos14
Oct 3, 2026
Merged

airween merged 1 commit into
owasp-modsecurity:v3/masterfrom
airween:v3/removemacos14

Conversation

@airween

@airween airween commented Oct 2, 2026 •

Copy link
Copy Markdown
Member

what

This PR removes macos-14 based jobs from "old" CI.

why

GH will remove these machines (macos-14*) from possible action runners. The other ci_new.yml runs the same tests, but uses the newest macos machines, which is suggested by Github.

references

Summary by CodeRabbit

  • Chores
    • Removed macOS builds and tests from the CI workflow.
    • Removed the static analysis check from the workflow.

@airween
airween requested review from fzipi and theseion and a balanced review from Copilot October 2, 2026 20:13
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 343b9871-76b6-41cb-aab5-7e71d6f37af8

📥 Commits

Reviewing files that changed from the base of the PR and between e1ccfff and b66a3ef.

📒 Files selected for processing (1)
  • .github/workflows/ci.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/ci.yml

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 5 remain after this review.


📝 Walkthrough

Walkthrough

The CI workflow removes the build-macos and cppcheck jobs, including their macOS setup, build, test, and static-analysis steps.

Changes

macOS CI job removal

Layer / File(s) Summary
Remove macOS build and static-analysis jobs
.github/workflows/ci.yml
The workflow no longer runs the macOS build matrix or the cppcheck job and its make check-static step.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b66a3

The removed CI checks remain available on newer macOS runners. No actionable merge risk remains beyond normal checks.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing macOS 14-related jobs from the CI workflow.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The removed coverage is retained on newer macOS runners in ci_new.yml.

Review effort: Balanced
Findings: None

What changed in this PR

Removes deprecated macOS 14 jobs from the legacy CI workflow; equivalent macOS builds and static analysis remain in ci_new.yml.

Changes:

  • Removes the macOS 14 build matrix.
  • Removes macOS 14 cppcheck analysis.
File Description
.github/​workflows/​ci.yml Removes CI jobs tied to the retiring macOS 14 runner.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@sonarqubecloud

sonarqubecloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

@airween
airween merged commit 48e561b into owasp-modsecurity:v3/master Oct 3, 2026
89 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants