Remove stale telemetry leftovers - #424
Open
mnapoli wants to merge 1 commit into
Open
Conversation
GrahamCampbell
left a comment
Contributor
There was a problem hiding this comment.
We need to be careful removing some of these, as they may be used by people requiring the package (Bref was using some stuff adjacent to this for example).
mnapoli
marked this pull request as ready for review
July 30, 2026 15:39
Contributor
Author
|
Yep, I'm fine dropping this if it's too risky. I've asked Fable to minimize risky deletes, that's why I ended up leaving one of the variable. I think what's left should be fine to merge, but this PR is not a priority tbh. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Telemetry was removed a while ago, but a few leftovers survived. This cleans them up:
lib/utils/get-framework-id.js,lib/utils/npm-package/is-global.jsandlib/utils/telemetry/are-disabled.js: all unused.disable-serverless-stats-requeststest helper, which existed only to stub the module above.variableSourcesInConfigtracking in the variables resolver: it recorded variable sources for telemetry, nothing reads it anymore.generatePayloadtelemetry logic.The
accountIdprefetch indeploy/removeandprovider.accountIdare kept as-is (plugins may rely on them), only their comments changed.Bref is not affected: it reads
frameworkIdthrough the@serverless/utils/configalias, which points to the vendoredconfig.js. Both are untouched, and I verified Bref's exact code path (from current bref master) still works against this branch.