Skip to content

Remove stale telemetry leftovers - #424

Open
mnapoli wants to merge 1 commit into
4.xfrom
cleanup-stale-telemetry-refs
Open

Remove stale telemetry leftovers#424
mnapoli wants to merge 1 commit into
4.xfrom
cleanup-stale-telemetry-refs

Conversation

@mnapoli

@mnapoli mnapoli commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Telemetry was removed a while ago, but a few leftovers survived. This cleans them up:

  • Deleted lib/utils/get-framework-id.js, lib/utils/npm-package/is-global.js and lib/utils/telemetry/are-disabled.js: all unused.
  • Deleted the disable-serverless-stats-requests test helper, which existed only to stub the module above.
  • Removed the variableSourcesInConfig tracking in the variables resolver: it recorded variable sources for telemetry, nothing reads it anymore.
  • Rewrote the outdated comments that still referenced the old generatePayload telemetry logic.

The accountId prefetch in deploy/remove and provider.accountId are kept as-is (plugins may rely on them), only their comments changed.

Bref is not affected: it reads frameworkId through the @serverless/utils/config alias, which points to the vendored config.js. Both are untouched, and I verified Bref's exact code path (from current bref master) still works against this branch.

@mnapoli
mnapoli requested a review from GrahamCampbell July 30, 2026 15:19

@GrahamCampbell GrahamCampbell left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to be careful removing some of these, as they may be used by people requiring the package (Bref was using some stuff adjacent to this for example).

@mnapoli
mnapoli marked this pull request as ready for review July 30, 2026 15:39
@mnapoli

mnapoli commented Jul 30, 2026

Copy link
Copy Markdown
Contributor Author

Yep, I'm fine dropping this if it's too risky. I've asked Fable to minimize risky deletes, that's why I ended up leaving one of the variable. I think what's left should be fine to merge, but this PR is not a priority tbh.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants