Skip to content

Propagate tidal parameters through GWSignal - #180

Draft
oshaughnessy-junior wants to merge 1 commit into
oshaughn:rift_O4cfrom
oshaughnessy-junior:codex/seobnrv5thm-tidal-gwsignal
Draft

Propagate tidal parameters through GWSignal#180
oshaughnessy-junior wants to merge 1 commit into
oshaughn:rift_O4cfrom
oshaughnessy-junior:codex/seobnrv5thm-tidal-gwsignal

Conversation

@oshaughnessy-junior

Copy link
Copy Markdown

Summary

  • pass P.lambda1 and P.lambda2 into all RIFT GWSignal generation paths
  • centralize construction of the GWSignal parameter dictionary
  • add a public tidal-waveform regression test and a native-mode generator sanity test

This intentionally does not special-case string approximants or impose a mode ceiling; those behaviors remain with GWSignal and downstream RIFT handling.

Validation

  • pytest -q MonteCarloMarginalizeCode/Code/test/waveform/test_gwsignal_tides.py
  • result in the available environment: 2 passed, 1 skipped
  • the optional native-mode generator test skipped because that generator is not registered in the installed environment
  • public TaylorT4 tidal-vs-zero-tide generation passed

@oshaughnessy-junior
oshaughnessy-junior deployed to private-review-dispatch-rift-upstream August 20, 2026 17:49 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants