Repository navigation
NO-ISSUE: Shorten the ci-maintainer role description - #281
Merged
Merged
Conversation
The description added with the branch protection bypass was 161 characters and GitHub accepts at most 152, so tofu apply failed with "422 Description cannot be longer than 152 characters" and every pending change of every repository waited for it. Shorten it to 126. Signed-off-by: Elior Erez <eerez@redhat.com>
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 1
✨ Finishing Touches
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The apply of the previous change (Let ci-duty bypass branch protections with its role) failed:
Error updating GitHub organization repository role (osac-project/ci-maintainer): PATCH .../custom-repository-roles/103023: 422 Description cannot be longer than 152 charactersThe description I extended with the bypass was 161 characters. This shortens it to 126 (
Write, plus Actions secrets, variables, environments, settings and runners, merge queue priority, and branch protection bypass). Nothing else changes: the role, its permissions (including bypass_branch_protection) and the README stay as they are. Until this is merged and applied, every pending Terraform change of every repository waits behind the failed apply (it filed an issue). Merging applies it (apply.yaml runs on a push to main that touches *.tf).The role itself was not updated by the failed apply, so the force-merge checkbox for ci-duty does not appear yet; it will once this is applied.
Not run locally: tofu is not installed here; the change is one string and the failed run's TF Init and Validate steps passed with the longer one.