Repository navigation
fix(ci): validate benchmarks and patch dependency advisories - #261
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The evaluator benchmark named
evaluate_flat_10_stepsconfigured one step with ten unrelated execution nodes and discarded its result. Failed workflows could therefore produce apparently valid timings. CI also omitted the standalone fuzz lockfile from dependency audits, allowing that graph to drift and retain vulnerable TLS dependencies.This change makes benchmark workloads verify their intended work and audits every tracked Rust lockfile:
ctutils0.4.3 to 0.4.4 in all four tracked lockfiles for RUSTSEC-2026-0385.rustls-webpkito 0.103.16 andwebpki-root-certsto 1.0.10 for RUSTSEC-2026-0382/0383. Synchronize its existing jsonschema 0.59 and serde_ignored manifest requirements.--lockedin every dependency audit. No advisory exception is added.Validation on current head
89747e94529b5178563c1624e30ca11d6f76196d:ctutils; these overlap the full suite, not an additional independent test count.All ten CI jobs, all twelve Mobile jobs and the full Benchmarks workflow passed before merge. PR #261 merged at 09:41:46 UTC as
77c60aeb9d4aeabd0ace5a66348831c68bb65b40; its treeae988ae56d6d1896add23421b863f02781b42506exactly matches the reviewed head. New-main CI and Mobile both completed successfully: all 22 individual jobs passed on exact merge commit77c60ae. The final main log confirms 9,910 workspace passes, zero failures, ten existing ignored cases and all 40 Criterion smoke cases passing. Additional all-feature/all-target compilation passed without warnings on the identical source tree.The 31/23-node labels replace misleading 100/500 labels, so those timing series start fresh. No throughput improvement is claimed.