Skip to content

Fix compile() unrecognised-flags ValueError crashing on its message #1232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jseop-lim wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix compile() unrecognised-flags ValueError crashing on its message #1232

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions graalpython/com.oracle.graal.python.test/src/tests/test_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,15 @@ def test_incomplete_input_error():
assert False, "SyntaxError was not raised"


def test_compile_unrecognised_flags_message():
try:
compile("1", "<input>", "exec", 0x7fffffff)
except ValueError as e:
assert str(e) == "compile(): unrecognised flags"
else:
assert False, "ValueError was not raised"


def test_lambdas_as_function_default_argument_values():
globs = {}
exec("""
Expand Down
2 changes: 1 addition & 1 deletion ...om.oracle.graal.python/src/com/oracle/graal/python/builtins/modules/BuiltinFunctions.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1143,7 +1143,7 @@ private void checkOptimize(int optimize, Object kwOptimize) throws PException {
@TruffleBoundary
private void checkFlags(int flags) {
if ((flags & ~(PyCF_MASK | PyCF_MASK_OBSOLETE | PyCF_COMPILE_MASK)) != 0) {
throw PRaiseNode.raiseStatic(this, ValueError, null, NO_VALUE, ErrorMessages.UNRECOGNIZED_FLAGS, PythonUtils.EMPTY_OBJECT_ARRAY);
throw PRaiseNode.raiseStatic(this, ValueError, ErrorMessages.UNRECOGNIZED_FLAGS);
}
}

Expand Down