[AI-FSSDK] [FSSDK-12368] Remove legacy flag-level holdout fields#395
Merged
esrakartalOpt merged 2 commits intomasterfrom Apr 23, 2026
Merged
Conversation
Remove deprecated included_flags and excluded_flags from Holdout model and simplify holdout handling to treat all holdouts as global. - Removed included_flags and excluded_flags from Holdout schema - Removed global_holdouts, included_holdouts_map, excluded_holdouts_map - Simplified holdout initialization to single holdout_map - Updated decision_service to use simplified holdout_map - Removed 13 legacy-specific test cases - Updated test fixtures to remove legacy fields All 1020 tests pass. Verification: grep for included_flags|excluded_flags returns 0 results. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove deprecated
included_flagsandexcluded_flagsfrom Holdout model and simplify holdout handling to treat all holdouts as global.Changes
included_flagsandexcluded_flagsfrom Holdout schemaglobal_holdouts,included_holdouts_map,excluded_holdouts_mapholdout_mapholdout_mapTesting
Quality Metrics
Related
🤖 Generated with Claude Code