Preserve reader links after hosted plans are inscribed - #12
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
#kreader-link fragment during that moveWhy
The server never receives URL fragments. The previous server redirect therefore dropped the reader secret, leaving wallet-free recipients unable to open the inscribed plan.
Live reproduction
A hosted plan was created with
bitplan 0.0.16 --link, inscribed successfully, and its hosted proxy returned the expected 410 with the chain origin. Opening the hosted reader link then moved to the chain URL without#k, reproducing the access failure.Verification
bun test— 474 passbun run --cwd apps/web checkbun run --cwd apps/web typecheck