🐛 e2e: skip clusterobjectset cleanup when BoxcutterRuntime is disabled#2662
Conversation
✅ Deploy Preview for olmv1 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Adjusts e2e scenario context initialization to avoid attempting ClusterObjectSet cleanup in suites where the CRD isn’t present (preventing noisy cleanup failures).
Changes:
- Stop pre-populating
clusterObjectSetNameinCreateScenarioContext, so cleanup only tries deleting a ClusterObjectSet when one was actually applied.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Scenario cleanup unconditionally attempted to delete the pre-generated clusterobjectset resource, but the CRD only exists when BoxcutterRuntime is enabled. Guard the deletion with a feature gate check. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
joelanford
force-pushed
the
fix-cos-cleanup-error
branch
from
fb9f3e6 to
25dfc4e
Compare
joelanford
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2662 +/- ##
==========================================
+ Coverage 68.89% 68.93% +0.03%
==========================================
Files 141 141
Lines 10009 10009
==========================================
+ Hits 6896 6900 +4
+ Misses 2596 2594 -2
+ Partials 517 515 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
/lgtm |
|
I had been seeing these messages, too. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tmshort The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
openshift-merge-bot
Bot
merged commit e45ca46
into
operator-framework:main
Description
Scenario cleanup unconditionally attempted to delete the pre-generated
clusterobjectsetresource, but the CRD only exists whenBoxcutterRuntimeis enabled. This produced the error:Guard the deletion with a
featureGates[features.BoxcutterRuntime]check so it's only attempted when the CRD exists.Reviewer Checklist