Skip to content

fix: missing override annotation - #3677

Merged
csviri merged 1 commit into
nextfrom
missing-override
Nov 5, 2026
Merged

csviri merged 1 commit into
nextfrom
missing-override

Conversation

@csviri

@csviri csviri commented Nov 5, 2026

Copy link
Copy Markdown
Collaborator

Signed-off-by: Attila Mészáros a_meszaros@apple.com

Copilot AI balanced review requested due to automatic review settings November 5, 2026 19:26
@openshift-ci
openshift-ci Bot requested review from metacosm and xstefank November 5, 2026 19:26
@coderabbitai

coderabbitai Bot commented Nov 5, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: b2681f3c-c192-4b6f-8af8-e40e23e61b93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No active review issues are reported for the change adding @Override to the test reconciler’s execution-count getter.

No open issues 🎉

What changed in this PR

Adds the missing @Override annotation to the virtual-thread test reconciler, making the method’s override explicit without changing runtime behavior.

Changes:

  • Annotates getNumberOfExecutions() with @Override.
File Description
operator-framework/​src/​test/​java/​io/​javaoperatorsdk/​operator/​baseapi/​virtualthreads/​VirtualThreadsTestReconciler.java Adds @Override to the execution-count getter.

Review effort: Balanced

Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
@csviri
csviri merged commit 84e7502 into next Nov 5, 2026
29 checks passed
@csviri
csviri deleted the missing-override branch November 5, 2026 23:32
csviri added a commit that referenced this pull request Nov 6, 2026
Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants