fix: set configuration service for default pool - #3535
Draft
csviri wants to merge 1 commit into
Draft
Conversation
This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it. Signed-off-by: Attila Mészáros <a_meszaros@apple.com>
openshift-ci
Bot
added
the
needs-rebase
csviri
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the default ConfigurationService#informerPool() implementation to ensure the returned DefaultInformerPool is properly initialized with the ConfigurationService, aligning the default pool’s lifecycle with the framework’s expected configuration injection behavior.
Changes:
- Initialize the default
DefaultInformerPoolwithsetConfigurationService(this)before returning it.
Comment on lines
500
to
+503
| default InformerPool informerPool() { | ||
| return new DefaultInformerPool(); | ||
| var pool = new DefaultInformerPool(); | ||
| pool.setConfigurationService(this); | ||
| return pool; |
csviri
marked this pull request as draft
August 1, 2026 19:51
openshift-ci
Bot
added
do-not-merge/work-in-progress
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is expected for a pool to set. Event if the underlying implementation would set it, this is the correct way to handle it.
TODO explicitly cache one time the Informer Pool