Changing place where windows CI artefacts are stored#4254
Open
przepeck wants to merge 22 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adjusts the Windows CI publishing step so artifacts are written to a versioned, timestamped directory layout (<PRODUCT_VERSION>/<RELEASE_TAG>/windows/<buildstamp>/...) with a refreshed latest/ copy, instead of overwriting a single per-branch zip. Also makes unit tests conditional on RUN_TESTS and introduces WORKER_CREDS.
Changes:
- Replace branch-based artifact filename with
ovms_windows_<PRODUCT_VERSION>_<RELEASE_TAG>_python_<on|off>.zipand publish into versioned +latestsubdirectories usingnet useto map the share. - Gate
unit_test/check_testsbehindenv.RUN_TESTS == "1". - Add
WORKER_CREDScredentials binding and abuildstamptimestamp.
przepeck
changed the title
rasapala
reviewed
Jun 9, 2026
| windows.check_tests() | ||
| if (env.RUN_TESTS == "1") { | ||
| windows.unit_test() | ||
| windows.check_tests() |
Collaborator
There was a problem hiding this comment.
removed on main windows.check_tests()
rasapala
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary
CVS-183935
Changing artifacts path to preserve history, when there are multiple packages with the same tags
🧪 Checklist
``