Remove unused fields from HorizonTest CR#474
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 11m 31s |
Parameters adminUsername and adminPassword are being deprecated in the test-operator [1]. Their defaults are also being removed, therefore it is needed to remove them in ci-framework as well. Parameters projectName, user, and password were never fully working in the test-operator, as the values were hardcoded regardless of what was set in the CR. The effort to remove them is in test-operator PR [2], which needs their removal in ci-framework as well. [1] openstack-k8s-operators/test-operator#473 [2] openstack-k8s-operators/test-operator#474 Signed-off-by: Katarina Strenkova <kstrenko@redhat.com>
The ProjectName, User, Password fields were never read by the controller. In TCIB it is hardcoded as "horizontest" regardless of what was set in the CR. Normally, I would recommend deprecation for parameters, but since these parameters never worked from the start, I suggest a removal. There is also no need for them to be parameters, as the Horizon team agreed they do not have to be overwritten and can stay hardcoded.
43ed59d to
2cb266c
Compare
|
@kstrenkova: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 11m 00s |
1 participant
The ProjectName, User, Password fields were never read by the controller. In TCIB it is hardcoded as "horizontest" regardless of what was set in the CR.
Normally, I would recommend deprecation for parameters, but since these parameters never worked from the start, I suggest a removal. There is also no need for them to be parameters, as the Horizon team agreed they do not have to be overwritten and can stay hardcoded.