Remove hardcoded passwords following install_yamls#1158#471
Conversation
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
3ed90e9 to
174e112
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
174e112 to
4a328f5
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
4a328f5 to
7d7836c
Compare
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
recheck |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 08m 35s |
|
recheck - LGTM, We just have to wait for the new tobiko image |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kstrenkova, Valkyrie00 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Build failed (check pipeline). Post ✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 47m 37s |
Thanks for the review! I have contacted @HanzJas for the HorizonTest part and seems more things have been failing for them than I thought. So we will need to wait for both Tobiko and Horizon, plus the tests will not pass otherwise anyway (recheck will not work). |
Hello @kstrenkova, yes, |
A recent change [1] in install_yamls repository replaced hardcoded passwords with dynamically generated secrets. To keep test-operator up to date, it is needed to also update/remove hardcoded passwords, which is the goal of this PR. The new dynamic passwords also break EnsureCloudsConfigMapExists which injected "12345678" into clouds.yaml when empty, but that value no longer matches the real admin password. This patch removes the workaround and has Tobiko and HorizonTest mount the original openstack-config ConfigMap directly. For HorizonTest, the password is read from osp-secret thanks to a ci-framework patch [2]. For Tobiko, a new way of supporting the password from secure.yaml is being worked on [3]. [1] openstack-k8s-operators/install_yamls#1158 [2] openstack-k8s-operators/ci-framework#4067 [3] https://review.opendev.org/c/x/tobiko/+/998010
7d7836c to
26b3cfc
Compare
|
I removed the change in |
|
Build failed (check pipeline). Post ❌ openstack-k8s-operators-content-provider FAILURE in 11m 12s |
3 participants
A recent change [1] in install_yamls repository replaced hardcoded passwords with dynamically generated secrets. To keep test-operator up to date, it is needed to also update/remove hardcoded passwords, which is the goal of this PR. The new dynamic passwords also break EnsureCloudsConfigMapExists which injected "12345678" into clouds.yaml when empty, but that value no longer matches the real admin password.
This patch removes the workaround and has Tobiko and HorizonTest mount the original openstack-config ConfigMap directly. For HorizonTest, the password is read from osp-secret thanks to a ci-framework patch [2]. For Tobiko, a new way of supporting the password from secure.yaml is being worked on [3].
[1] openstack-k8s-operators/install_yamls#1158
[2] openstack-k8s-operators/ci-framework#4067
[3] https://review.opendev.org/c/x/tobiko/+/998010