Skip to content

Release test-operator-lock on CR deletion#466

Open
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:add-finalizers-release-lock
Open

Release test-operator-lock on CR deletion#466
kstrenkova wants to merge 1 commit into
openstack-k8s-operators:mainfrom
kstrenkova:add-finalizers-release-lock

Conversation

@kstrenkova

@kstrenkova kstrenkova commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Previously, deleting a CR while its pod held the test-operator-lock left the lock stuck, blocking all other CR instances indefinitely. Finalizers are now added unconditionally so the lock is always released during deletion.

@openshift-ci

openshift-ci Bot commented Jul 16, 2026

Copy link
Copy Markdown

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@kstrenkova
kstrenkova marked this pull request as ready for review July 21, 2026 11:24
@openshift-ci
openshift-ci Bot requested review from abays and stuggi July 21, 2026 11:24
@kstrenkova
kstrenkova force-pushed the add-finalizers-release-lock branch from 2361ec9 to 2c0052f Compare July 21, 2026 12:05
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/d756df5332fa4d87abed248848649bac

openstack-k8s-operators-content-provider FAILURE in 13m 05s
⚠️ test-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

@kstrenkova
kstrenkova force-pushed the add-finalizers-release-lock branch from 2c0052f to 1db8754 Compare July 21, 2026 12:37
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/84b6b2ba44fe4206870ed832790bf426

openstack-k8s-operators-content-provider FAILURE in 12m 36s
⚠️ test-operator-kuttl SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider
⚠️ podified-multinode-edpm-deployment-crc-test-operator SKIPPED Skipped due to failed job openstack-k8s-operators-content-provider

Previously, deleting a CR while its pod held the
test-operator-lock could leave the lock stuck, blocking other CR
instances indefinitely. Although, GC usually cleans it up in time,
it is for the best to support explicit cleanup. Therefore,
finalizers are now added unconditionally so the lock is always
released during deletion.
@kstrenkova
kstrenkova force-pushed the add-finalizers-release-lock branch from 1db8754 to 3b699f8 Compare July 21, 2026 13:08
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/598617aa89ec488fbebf29dc4921f424

✔️ openstack-k8s-operators-content-provider SUCCESS in 1h 02m 19s
✔️ test-operator-kuttl SUCCESS in 43m 21s
podified-multinode-edpm-deployment-crc-test-operator RETRY_LIMIT in 5m 18s

@kstrenkova

Copy link
Copy Markdown
Contributor Author

recheck

@kstrenkova kstrenkova added the ready-for-review Marks additional review needed label Jul 22, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/62f63516bff24b34a43a9f86a5589947

✔️ openstack-k8s-operators-content-provider SUCCESS in 2h 59m 49s
✔️ test-operator-kuttl SUCCESS in 44m 32s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 42m 56s

@imatza-rh

Copy link
Copy Markdown

/lgtm
/approve

@openshift-ci

openshift-ci Bot commented Jul 23, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imatza-rh, kstrenkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kstrenkova

Copy link
Copy Markdown
Contributor Author

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/29b20f13fb354d3792b2d1c92853fcec

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 04m 01s
✔️ test-operator-kuttl SUCCESS in 48m 00s
podified-multinode-edpm-deployment-crc-test-operator FAILURE in 2h 41m 35s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm ready-for-review Marks additional review needed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants