Skip to content

[reproducer] Remove invalid import_role options#3885

Open
bogdando wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
bogdando:reuse_main
Open

[reproducer] Remove invalid import_role options#3885
bogdando wants to merge 1 commit intoopenstack-k8s-operators:mainfrom
bogdando:reuse_main

Conversation

@bogdando
Copy link
Copy Markdown
Contributor

The "Bootstrap environment on controller-0" task was refactored from ansible.builtin.command to ansible.builtin.import_role (712ef7d) but the args/chdir and changed_when directives were left behind. These are only valid for command/shell modules. ansible-core 2.15 now strictly validates import_role options and rejects chdir at parse time.

Generated-by: claude-4.6-opus-high

@bogdando bogdando requested review from danpawlik and eshulman2 April 23, 2026 09:21
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 23, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign brjackma for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

danpawlik
danpawlik previously approved these changes Apr 24, 2026
The "Bootstrap environment on controller-0" task was refactored from
ansible.builtin.command to ansible.builtin.import_role (712ef7d) but
the args/chdir and changed_when directives were left behind. These
are only valid for command/shell modules. ansible-core 2.15 now
strictly validates import_role options and rejects chdir at parse time.

Generated-by: claude-4.6-opus-high
Signed-off-by: Bohdan Dobrelia <bdobreli@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants