Skip to content

OCPBUGS-86881:[release-4.12] bump google.golang.org/grpc to v1.64.1-sec.1#97

Open
AkashMore08 wants to merge 1 commit into
openshift:release-4.12from
AkashMore08:release-4.12_CVE-2026-33186
Open

OCPBUGS-86881:[release-4.12] bump google.golang.org/grpc to v1.64.1-sec.1#97
AkashMore08 wants to merge 1 commit into
openshift:release-4.12from
AkashMore08:release-4.12_CVE-2026-33186

Conversation

@AkashMore08

Copy link
Copy Markdown

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 for release-4.14 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.

Along with the CVE fix, I had to manually pinned the otel modules at v0.20.0

Why 7 otel module are pinned at v0.20.0?

The grpc-go bump to v1.64.1-sec.1 pulls in newer transitive dependencies, that force go.opentelemetry.io/otel/metric from v0.20.0 to v1.24.0.
(cloud.google.com/go/compute → google.golang.org/api → otelgrpc@v0.49.0)

The v1.24.0 release removed subpackages (metric/number, metric/registry, metric/global, metric/sdkapi) that the vendored go.opentelemetry.io/otel/exporters/otlp@v0.20.0 (used by k8s.io/component-base/tracing in k8s 1.25) still depends on. Pinning the 7 otel modules at v0.20.0 prevents this version cascade while keeping the grpc CVE fix in place.

…ec.1 with manually pinning the otel to v0.20.0 to avoid dependency chain breaking
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@AkashMore08: This pull request references Jira Issue OCPBUGS-86881, which is invalid:

  • expected Jira Issue OCPBUGS-86881 to depend on a bug targeting a version in 4.13.0, 4.13.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 for release-4.14 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.

Along with the CVE fix, I had to manually pinned the otel modules at v0.20.0

Why 7 otel module are pinned at v0.20.0?

The grpc-go bump to v1.64.1-sec.1 pulls in newer transitive dependencies, that force go.opentelemetry.io/otel/metric from v0.20.0 to v1.24.0.
(cloud.google.com/go/compute → google.golang.org/api → otelgrpc@v0.49.0)

The v1.24.0 release removed subpackages (metric/number, metric/registry, metric/global, metric/sdkapi) that the vendored go.opentelemetry.io/otel/exporters/otlp@v0.20.0 (used by k8s.io/component-base/tracing in k8s 1.25) still depends on. Pinning the 7 otel modules at v0.20.0 prevents this version cascade while keeping the grpc CVE fix in place.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from adambkaplan and csrwng June 12, 2026 10:39
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkashMore08
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4475868-51c5-4a15-9c64-5acb4b95fc1e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@AkashMore08: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants