Skip to content

OCPBUGS-86884:[release-4.13] bump google.golang.org/grpc to v1.64.1-sec.1#96

Open
AkashMore08 wants to merge 1 commit into
openshift:release-4.13from
AkashMore08:release-4.13_CVE-2026-33186
Open

OCPBUGS-86884:[release-4.13] bump google.golang.org/grpc to v1.64.1-sec.1#96
AkashMore08 wants to merge 1 commit into
openshift:release-4.13from
AkashMore08:release-4.13_CVE-2026-33186

Conversation

@AkashMore08

Copy link
Copy Markdown

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 for release-4.13 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.

Along with the CVE fix, we had to manually bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.17.0.

Why otlptracegrpc was bumped to v1.17.0?

Replacing google.golang.org/grpc with v1.64.1-sec.1 changes the module graph the new grpc version requires higher minimum versions of shared dependencies (google.golang.org/protobuf v1.33.0, golang.org/x/net v0.26.0, etc.). This forces go mod tidy to re-resolve the entire dependency tree, which exposes a pre-existing broken module resolution in otlptracegrpc v1.10.0 through v1.16.0.

These versions depend on internal packages (go.opentelemetry.io/otel/exporters/otlp/internal, go.opentelemetry.io/otel/exporters/otlp/internal/envconfig) that were resolved via local replace directives within the OpenTelemetry monorepo during development. When consumed from the Go module proxy, those local replaces are ignored, and go mod tidy fails because the enclosing module (go.opentelemetry.io/otel/exporters/otlp@v0.20.1) does not contain these packages.

otlptracegrpc v1.17.0 is the first version that inlined these internal packages and removed the broken external module dependency. This bump then transitively upgrades otelgrpc (from v0.35.0 to v0.49.0), the core otel SDK, and other shared dependencies are auto-resolved by go mod tidy.

…ec.1 with manually bumping the otlptracegrpc to v1.17.0
@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@AkashMore08: This pull request references Jira Issue OCPBUGS-86884, which is invalid:

  • expected Jira Issue OCPBUGS-86884 to depend on a bug targeting a version in 4.14.0, 4.14.z and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Address CVE-2026-33186 via transitive dependency update

This PR resolves CVE-2026-33186 for release-4.13 by replacing google.golang.org/grpc with github.com/openshift-sustaining/grpc-go@v1.64.1-sec.1, a patched fork containing security fixes equivalent to upstream v1.79.3.

Along with the CVE fix, we had to manually bump go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc to v1.17.0.

Why otlptracegrpc was bumped to v1.17.0?

Replacing google.golang.org/grpc with v1.64.1-sec.1 changes the module graph the new grpc version requires higher minimum versions of shared dependencies (google.golang.org/protobuf v1.33.0, golang.org/x/net v0.26.0, etc.). This forces go mod tidy to re-resolve the entire dependency tree, which exposes a pre-existing broken module resolution in otlptracegrpc v1.10.0 through v1.16.0.

These versions depend on internal packages (go.opentelemetry.io/otel/exporters/otlp/internal, go.opentelemetry.io/otel/exporters/otlp/internal/envconfig) that were resolved via local replace directives within the OpenTelemetry monorepo during development. When consumed from the Go module proxy, those local replaces are ignored, and go mod tidy fails because the enclosing module (go.opentelemetry.io/otel/exporters/otlp@v0.20.1) does not contain these packages.

otlptracegrpc v1.17.0 is the first version that inlined these internal packages and removed the broken external module dependency. This bump then transitively upgrades otelgrpc (from v0.35.0 to v0.49.0), the core otel SDK, and other shared dependencies are auto-resolved by go mod tidy.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: e1434ae1-2b6e-4eab-b8ab-f0a80362006a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from bparees and csrwng June 12, 2026 10:32
@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: AkashMore08
Once this PR has been reviewed and has the lgtm label, please assign bparees for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci

openshift-ci Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

@AkashMore08: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants