Skip to content

[WIP] Support a release controller for layered operators - #804

Draft
JoelSpeed wants to merge 2 commits into
openshift:mainfrom
JoelSpeed:hypershift-release-controller
Draft

[WIP] Support a release controller for layered operators#804
JoelSpeed wants to merge 2 commits into
openshift:mainfrom
JoelSpeed:hypershift-release-controller

Conversation

@JoelSpeed

Copy link
Copy Markdown
Contributor

This PR adds a new Layered mode for the release controller and teaches the release-payload-controller how to handle a ReleasePayload that doesn't need any build or mirror step.

Important things:

  • The release controller now does not put a release creation or release mirroring config in place
    • This is the signal to the release payload controller that no build needs to happen
    • This seemed like a clean way to handle the hand-off between the two components, but open to something explicit
  • In the release payload controller, the payload creation controller adds a status for the job creation result
    • This bit is slightly hacky? It causes the job creation result controller to short-circuit, but perhaps we want to add logic directly to that controller instead to handle this case
    • We could avoid having to set this status at all if we taught the payload accepted controller how to understand that no payload creation job exists, not sure which is a better architectural decision here

@coderabbitai

coderabbitai Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 1d1d0bcd-fa67-4efb-9416-7775f88ba382

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 24, 2026
@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci

openshift-ci Bot commented Jul 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JoelSpeed
Once this PR has been reviewed and has the lgtm label, please assign hoxhaeris for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant