Skip to content

CNTRLPLANE-3629: authentication: skip external oidc kube-apiserver configuration check when new architecture gate is enabled #31314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
everettraven wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

CNTRLPLANE-3629: authentication: skip external oidc kube-apiserver configuration check when new architecture gate is enabled #31314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions test/extended/authentication/oidc.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
g "github.com/onsi/ginkgo/v2"
o "github.com/onsi/gomega"
configv1 "github.com/openshift/api/config/v1"
"github.com/openshift/api/features"
operatorv1 "github.com/openshift/api/operator/v1"
routev1 "github.com/openshift/api/route/v1"
operatorv1client "github.com/openshift/client-go/operator/clientset/versioned/typed/operator/v1"
Expand Down Expand Up @@ -125,6 +126,25 @@ var _ = g.Describe("[sig-auth][Suite:openshift/auth/external-oidc][Serial][Slow]

g.Describe("external IdP is configured", g.Ordered, func() {
g.It("should configure kube-apiserver", func() {
// Get the FeatureGates resource
fgs, err := oc.AdminConfigClient().ConfigV1().FeatureGates().Get(context.TODO(), "cluster", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred(), "error getting cluster FeatureGates.")

// Loop through the feature gates to see if the desired one is enabled
externalClaimsSourcingEnabled := false
for _, fg := range fgs.Status.FeatureGates {
for _, enabledFG := range fg.Enabled {
if enabledFG.Name == features.FeatureGateExternalOIDCExternalClaimsSourcing {
externalClaimsSourcingEnabled = true
break
}
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

if externalClaimsSourcingEnabled {
g.Skip("ExternalOIDCExternalClaimsSourcing is enabled which makes this test case obsolete, skipping.")
}

kas, err := oc.AdminOperatorClient().OperatorV1().KubeAPIServers().Get(ctx, "cluster", metav1.GetOptions{})
o.Expect(err).NotTo(o.HaveOccurred(), "should not encounter an error getting the kubeapiservers.operator.openshift.io/cluster")

Expand Down