Conversation
| . Determine the metrics set value to use for each cluster. | ||
| + | ||
| The annotation enables forwarding but does not specify a metrics set. | ||
| The HyperShift Operator uses the global `METRICS_SET` environment variable as the source. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid usage of "HyperShift".
| -o jsonpath='{.spec.template.spec.containers[?(@.name=="operator")].env[?(@.name=="METRICS_SET")].value}' | ||
| ---- | ||
| + | ||
| `hypershift` is the namespace where the HyperShift Operator is typically installed, |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid usage of "HyperShift".
| You can enable and configure control plane metrics forwarding independently for each hosted cluster | ||
| by setting the `spec.monitoring.metricsForwarding` field on the `HostedCluster` object. | ||
| This lets you select different metrics sets for different hosted clusters on the same management cluster | ||
| without changing the global HyperShift Operator configuration. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid usage of "HyperShift".
| Replace `<hosted_cluster_namespace>` with the namespace of the hosted cluster | ||
| and `<hosted_cluster_name>` with the name of the hosted cluster. | ||
| + | ||
| When you set `mode: Forward`, the HyperShift Operator deploys the `metrics-proxy` and |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid usage of "HyperShift".
| . Optional: Set the metrics set for this hosted cluster. | ||
| + | ||
| If you omit this step, the cluster inherits the global `METRICS_SET` environment variable | ||
| from the HyperShift Operator deployment, which defaults to `Telemetry`. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid usage of "HyperShift".
48a9124 to
018db48
Compare
|
|
||
| . `spec.monitoring.metricsForwarding.metricsSet` on the `HostedCluster` object | ||
| . `spec.monitoring.metricsSet` on the `HostedCluster` object | ||
| . Global `METRICS_SET` environment variable on the HyperShift Operator deployment (defaults to `Telemetry` if not set) |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid use of "HyperShift".
| = Configuring per-cluster control plane metrics forwarding | ||
|
|
||
| [role="_abstract"] | ||
| You can enable and configure control plane metrics forwarding independently for each hosted cluster by setting the `spec.monitoring.metricsForwarding` field on the `HostedCluster` object. As a result, you can select different metrics sets for different hosted clusters on the same management cluster without changing the global HyperShift Operator configuration. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. "HyperShift Operator" is a valid use of "HyperShift".
| + | ||
| [NOTE] | ||
| ==== | ||
| If the deprecated `hypershift.openshift.io/enable-metrics-forwarding` annotation is also set on the `HostedCluster` object, the `spec.monitoring.metricsForwarding` field takes precedence. For information about the deprecated annotation and migrating to the new API, see "Deprecated annotation: hypershift.openshift.io/enable-metrics-forwarding". |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'hypershift'. For more information, see RedHat.TermsErrors.
There was a problem hiding this comment.
Ignoring. This usage is a valid usage of "hypershift".
018db48 to
1ead607
Compare
871d0c5 to
a795701
Compare
a795701 to
3f574fe
Compare
| + | ||
| The annotation continues to be honored when `spec.monitoring` is not set on the `HostedCluster` object. If you set `spec.monitoring.metricsForwarding` on a cluster, the spec field takes precedence and the annotation is ignored for that cluster, even if both are present. | ||
| + | ||
| Migrate all hosted clusters that use the `hypershift.openshift.io/enable-metrics-forwarding` annotation to use `spec.monitoring.metricsForwarding` before the annotation is removed in a future release. For more information, see xref:../hosted_control_planes/hcp-observability.adoc#hcp-cp-metrics-forwarding-migrate_hcp-observability[Migrating from annotation-based to API-based metrics forwarding]. |
There was a problem hiding this comment.
🤖 [error] OpenShiftAsciiDoc.NoXrefInModules: Do not include xrefs in modules, only assemblies (exception: release notes modules).
5341e3c to
f527755
Compare
f527755 to
9364459
Compare
| -o jsonpath='{.spec.template.spec.containers[?(@.name=="operator")].env[?(@.name=="METRICS_SET")].value}' | ||
| ---- | ||
| + | ||
| In the command, `hypershift` is the namespace where the HyperShift Operator is typically installed, and `operator` is the standard deployment name. These values might differ in non-standard installations. |
There was a problem hiding this comment.
🤖 [error] RedHat.TermsErrors: Use 'hosted control planes' rather than 'HyperShift'. For more information, see RedHat.TermsErrors.
|
@lahinson: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Version(s): 5.0+ (will be released after OCP 5.0 GA because HCP is an async release)
Issue: https://redhat.atlassian.net/browse/OSDOCS-22109
Link to docs preview:
QE review:
Additional information: