Bump Go toolchain to 1.25.3 to fix covdata unit test failure#2290
Bump Go toolchain to 1.25.3 to fix covdata unit test failure#2290weshayutin wants to merge 3 commits into
Conversation
Go 1.25.0 has a bug where packages with no test files cause "go: no such tool covdata" errors when run with -coverprofile, resulting in a non-zero exit code from go test. This was fixed in later patch releases. Bumping the toolchain directive ensures CI downloads go1.25.3 instead of using the broken go1.25.0. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository: openshift/coderabbit/.coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Please upload reports for the commit 92c836a to get more accurate results. Additional details and impacted files@@ Coverage Diff @@
## oadp-1.3 #2290 +/- ##
============================================
- Coverage 39.11% 31.36% -7.75%
============================================
Files 18 28 +10
Lines 3068 4489 +1421
============================================
+ Hits 1200 1408 +208
- Misses 1731 2915 +1184
- Partials 137 166 +29 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…verage The previous toolchain bump alone did not fix the covdata error. Following the oadp-dev branch pattern: - Set go directive to 1.25.0 and remove the toolchain line - Simplify submit-coverage target with --nonZero flag - Add SED = gsed for macOS compatibility The CI config in openshift/release will also need updating to set GOTOOLCHAIN=go1.25.0+auto (matching oadp-dev's CI config). Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
|
fyi required go bump in openshift/release#81579 is posted |
|
after that merge retest should be all it takes |
|
/retest |
|
@weshayutin: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/hold |
|
/unhold |
|
this is needed for #2275 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Joeavaikath, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
toolchaindirective ingo.modfromgo1.23.6togo1.25.3go test -coverprofileemitsgo: no such tool "covdata"errors for packages with no test files, causing the test command to return a non-zero exit codeunit-testCI job (e.g. build log)Test plan
go vetpasses locallycovdataerrorsunit-testjob passes on this PRMade with Cursor