Skip to content

Bump Go toolchain to 1.25.3 to fix covdata unit test failure#2290

Open
weshayutin wants to merge 3 commits into
openshift:oadp-1.3from
weshayutin:fix/go-toolchain-covdata-bug
Open

Bump Go toolchain to 1.25.3 to fix covdata unit test failure#2290
weshayutin wants to merge 3 commits into
openshift:oadp-1.3from
weshayutin:fix/go-toolchain-covdata-bug

Conversation

@weshayutin

Copy link
Copy Markdown
Contributor

Summary

  • Bumps the toolchain directive in go.mod from go1.23.6 to go1.25.3
  • Go 1.25.0 has a bug where go test -coverprofile emits go: no such tool "covdata" errors for packages with no test files, causing the test command to return a non-zero exit code
  • This broke the unit-test CI job (e.g. build log)
  • The fix is in Go 1.25.1+; bumping the toolchain directive ensures CI downloads a patched Go version

Test plan

  • go vet passes locally
  • Unit tests pass locally with no covdata errors
  • CI unit-test job passes on this PR

Made with Cursor

Go 1.25.0 has a bug where packages with no test files cause
"go: no such tool covdata" errors when run with -coverprofile,
resulting in a non-zero exit code from go test. This was fixed
in later patch releases. Bumping the toolchain directive ensures
CI downloads go1.25.3 instead of using the broken go1.25.0.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: afcf4c4d-4fe9-40b5-8244-b59f0321392d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot requested review from Joeavaikath and sseago July 7, 2026 16:16
@codecov-commenter

codecov-commenter commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.36%. Comparing base (e8ee8c5) to head (916b298).
⚠️ Report is 85 commits behind head on oadp-1.3.

⚠️ Current head 916b298 differs from pull request most recent head 92c836a

Please upload reports for the commit 92c836a to get more accurate results.

Additional details and impacted files
@@             Coverage Diff              @@
##           oadp-1.3    #2290      +/-   ##
============================================
- Coverage     39.11%   31.36%   -7.75%     
============================================
  Files            18       28      +10     
  Lines          3068     4489    +1421     
============================================
+ Hits           1200     1408     +208     
- Misses         1731     2915    +1184     
- Partials        137      166      +29     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

weshayutin and others added 2 commits July 7, 2026 11:00
…verage

The previous toolchain bump alone did not fix the covdata error.
Following the oadp-dev branch pattern:
- Set go directive to 1.25.0 and remove the toolchain line
- Simplify submit-coverage target with --nonZero flag
- Add SED = gsed for macOS compatibility

The CI config in openshift/release will also need updating to set
GOTOOLCHAIN=go1.25.0+auto (matching oadp-dev's CI config).

Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Wesley Hayutin <weshayutin@gmail.com>
@kaovilai

kaovilai commented Jul 7, 2026

Copy link
Copy Markdown
Member

fyi required go bump in openshift/release#81579 is posted

@kaovilai

kaovilai commented Jul 7, 2026

Copy link
Copy Markdown
Member

after that merge retest should be all it takes

@weshayutin

Copy link
Copy Markdown
Contributor Author

/retest

@openshift-ci

openshift-ci Bot commented Jul 7, 2026

Copy link
Copy Markdown

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@weshayutin

Copy link
Copy Markdown
Contributor Author

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026
@weshayutin

Copy link
Copy Markdown
Contributor Author

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 7, 2026
@weshayutin

Copy link
Copy Markdown
Contributor Author

this is needed for #2275

@openshift-ci

openshift-ci Bot commented Jul 8, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Joeavaikath, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants