Skip to content

HOLD: [release-4.22] Test drive KAS pre-hook patch #6788

Open
copejon wants to merge 1 commit into
openshift:release-4.22from
copejon:fix-USHIFT-6401-release-4.22
Open

HOLD: [release-4.22] Test drive KAS pre-hook patch #6788
copejon wants to merge 1 commit into
openshift:release-4.22from
copejon:fix-USHIFT-6401-release-4.22

Conversation

@copejon
Copy link
Copy Markdown
Contributor

@copejon copejon commented Jun 2, 2026

No description provided.

Thread a 5s context.WithTimeout into each poll attempt of the RBAC
bootstrap PostStartHook, preventing indefinite hangs when etcd is
unresponsive during initial readiness checks. Replace context.TODO()
with the deadline-scoped context in List calls and prime functions.
Add a klog.Warningf on timeout to distinguish deadline exceeded from
other transient errors.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jun 2, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 3ced2e9f-88ae-4a71-8d1b-f7b3bf88ee3e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from jerpeter1 and pmtk June 2, 2026 13:15
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 2, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: copejon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 2, 2026
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 2, 2026

/test e2e-aws-tests-bootc-arm-el9

9 similar comments
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 2, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

/test e2e-aws-tests-bootc-arm-el9

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 3, 2026

Closing — the e2e-aws-tests-bootc-arm-el9 failure could not be reproduced after 8 consecutive passes over ~20h of monitoring. The original failure was an infrastructure flake.

@copejon copejon closed this Jun 3, 2026
@copejon copejon reopened this Jun 7, 2026
@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 7, 2026

/hold

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 7, 2026
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Jun 7, 2026

/test

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Jun 7, 2026

/test ?

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Jun 7, 2026

/test e2e-aws-tests-bootc-release-arm-el9

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 7, 2026

@copejon: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-tests-bootc-release-arm-el9 16deac5 link true /test e2e-aws-tests-bootc-release-arm-el9

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 7, 2026

The base OS on the test is 9.6 when the test asserts 9.8

@copejon
Copy link
Copy Markdown
Contributor Author

copejon commented Jun 8, 2026

ci/prow/e2e-aws-tests-bootc-release-arm-el9 Version assertion was fixed last week in #6776

/unhold
/test e2e-aws-tests-bootc-release-arm-el9

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants