Skip to content

[release-4.19] NO-ISSUE: Add pprof endpoint to machine-controller-manager - #192

Closed
perdasilva wants to merge 2 commits into
openshift:release-4.19from
perdasilva:fix/pprof-endpoints-4.19
Closed

perdasilva wants to merge 2 commits into
openshift:release-4.19from
perdasilva:fix/pprof-endpoints-4.19

Conversation

@perdasilva

@perdasilva perdasilva commented Jun 3, 2026

Copy link
Copy Markdown

Cherry-pick of #189 to release-4.19.

Summary

  • Serve net/http/pprof handlers over TLS on a dedicated port (default :6060) so heap, goroutine, and allocs profiles are available via oc port-forward without rebuilding
  • The server runs on all replicas regardless of leader election
  • New --pprof-bind-address CLI flag to configure the endpoint binding

Test Plan

  • make unit passes with race detector
  • make vet and gofmt clean
  • Unit test: TLS startup and endpoint responsiveness
  • Unit test: graceful shutdown behavior

Per G. da Silva added 2 commits June 3, 2026 09:26
Serve net/http/pprof handlers over TLS on a dedicated port
(default :6060) so heap, goroutine, and allocs profiles are
available via oc port-forward without rebuilding. The server
runs on all replicas regardless of leader election.
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@perdasilva: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 72892481-93ae-4919-8550-d9f513d5ce6d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@perdasilva

Copy link
Copy Markdown
Author

/hold testing

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2026
@openshift-ci
openshift-ci Bot requested review from sub-mod and theobarberbany June 3, 2026 07:30
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign joelspeed for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@perdasilva perdasilva changed the title NO-ISSUE: Fix/pprof endpoints 4.19 [release-4.19] NO-ISSUE: Add pprof endpoint to machine-controller-manager Jun 3, 2026
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

@perdasilva: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws 34f6a1f link true /test e2e-aws

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@perdasilva perdasilva closed this Jun 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants